Skip to content

Bug fixes#74

Merged
supriyopaul merged 3 commits intodeep-compute:masterfrom
supriyopaul:bug_fixes
Mar 24, 2018
Merged

Bug fixes#74
supriyopaul merged 3 commits intodeep-compute:masterfrom
supriyopaul:bug_fixes

Conversation

@supriyopaul
Copy link
Copy Markdown
Contributor

There was a bug in the code due to which collector was sending msgs of more than 5mb limit to nsq. Which resulted in :

{"exception": "Traceback (most recent call last):\n  File \"/usr/local/lib/python2.7/dist-packages/deeputil/keep_running.py\", line 150, in _fn\n    fn(*args, **kwargs)\n  File \"/usr/local/lib/python2.7/dist-packages/logagg/nsqsender.py\", line 85, in _send_messages\n    self.session.post(url, data=data, timeout=5) # TODO What if session expires?\n  File \"/usr/local/lib/python2.7/dist-packages/requests/sessions.py\", line 555, in post\n    return self.request('POST', url, data=data, json=json, **kwargs)\n  File \"/usr/local/lib/python2.7/dist-packages/requests/sessions.py\", line 508, in request\n    resp = self.send(prep, **send_kwargs)\n  File \"/usr/local/lib/python2.7/dist-packages/requests/sessions.py\", line 618, in send\n    r = adapter.send(request, **kwargs)\n  File \"/usr/local/lib/python2.7/dist-packages/requests/adapters.py\", line 490, in send\n    raise ConnectionError(err, request=request)\nConnectionError: ('Connection aborted.', error(32, 'Broken pipe'))", "level": "error", "timestamp": "2018-03-21T10:37:11.528014Z", "id": "20180321T103711_d020b892-2cf3-11e8-96db-0242ac110003", "fn": "_send_messages", "type": "log", "tb": "'Traceback (most recent call last):\\n  File \"/usr/local/lib/python2.7/dist-packages/deeputil/keep_running.py\", line 150, in _fn\\n    fn(*args, **kwargs)\\n  File \"/usr/local/lib/python2.7/dist-packages/logagg/nsqsender.py\", line 85, in _send_messages\\n    self.session.post(url, data=data, timeout=5) # TODO What if session expires?\\n  File \"/usr/local/lib/python2.7/dist-packages/requests/sessions.py\", line 555, in post\\n    return self.request(\\'POST\\', url, data=data, json=json, **kwargs)\\n  File \"/usr/local/lib/python2.7/dist-packages/requests/sessions.py\", line 508, in request\\n    resp = self.send(prep, **send_kwargs)\\n  File \"/usr/local/lib/python2.7/dist-packages/requests/sessions.py\", line 618, in send\\n    r = adapter.send(request, **kwargs)\\n  File \"/usr/local/lib/python2.7/dist-packages/requests/adapters.py\", line 490, in send\\n    raise ConnectionError(err, request=request)\\nConnectionError: (\\'Connection aborted.\\', error(32, \\'Broken pipe\\'))\\n'", "event": "error_during_run_Continuing", "_": {"ln": 35, "file": "/usr/local/lib/python2.7/dist-packages/logagg/util.py", "name": "logagg.util", "fn": "log_exception"}}

@ghost ghost assigned supriyopaul Mar 23, 2018
@ghost ghost added the Status: Needs review label Mar 23, 2018
@supriyopaul supriyopaul requested review from a user, Anusha0812 and prashanthellina March 23, 2018 06:45
@supriyopaul supriyopaul merged commit b049635 into deep-compute:master Mar 24, 2018
@ghost ghost removed the Status: Needs review label Mar 24, 2018
@supriyopaul supriyopaul deleted the bug_fixes branch March 24, 2018 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants