num_shards fix#45
Merged
prashanthellina merged 2 commits intomasterfrom Mar 4, 2020
Merged
Conversation
IdavalapatiRamanjaneyulu
requested review from
jaswanth098,
prashanthellina and
sriharsha-kms
prashanthellina
previously approved these changes
Mar 3, 2020
Contributor
Author
|
My bad, forgot to update the version. Changed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It works when we have 6000001 vectors and num_vec_per_shard is 2M. For example (6000001/2000000)+1 gives 4.
But the problem comes when we have 6000000 vectors. In that case also we will get 4 shards instead of 3.