feat: startup_banner config, Theme migration in app.rs#3
Merged
Conversation
…scaffolding - Add startup_banner: Option<String> to RuntimeFeatureConfig in runtime crate - Add parse_optional_startup_banner() parser for 'startupBanner' config key - Add RuntimeConfig::startup_banner() accessor - Wire BannerStyle::from_config() in run_repl() — reads settings.json - Migrate full_banner() and compact_banner() to use Theme::DIM/Theme::RESET - Add None arg to run_repl() call sites for new startup_banner parameter - 230 tests pass, runtime crate compiles clean Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three self-contained improvements on top of the merged TUI refactor (PR #2):
1. Config-pluggable startup banner
startup_banner: Option<String>field toRuntimeFeatureConfigin theruntimecrateparse_optional_startup_banner()parser readingstartupBannerfromsettings.jsonRuntimeConfig::startup_banner()accessorrun_repl()resolves banner style from config ("full"/"compact"/"none") when no explicit flag is passed2. Theme migration in app.rs
full_banner()andcompact_banner()now useTheme::DIM/Theme::RESETwith named format args\x1b[2m/\x1b[0msequences3. Scaffolding for future
complete_tool()startup_banner: Option<BannerStyle>parameter torun_repl()signatureNone(preserving current behavior)Verification
cargo test -p rusty-claude-cli --bin claw— 230 passedcargo test --workspace— 228 passed (2 pre-existing flaky init tests)cargo check -p runtime— clean