Fix partial matching issues in tests #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One complication is the changes to R/splom.R. Basically we have a contradiction between the package source and what's tested:
lattice/tests/test.R
Line 91 in f216545
In effect, under partial matching, any
pscalesentry with a name starting withlimis accepted, but any user with strict matching rules must supplylim.If the intention truly is to let the user supply any
^lim.*list item, that should be better encoded in the sources (and perhaps documented); this PR assumes the test is in error instead to avoid back-compatibility issues.Details
To reproduce: