-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor CSS structure and implement responsive two-column layout #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add About section content
feat: add About section content
feat: add Resume section content
feature/section-portfolio
feat: add Blog section content
feat: add Contact section content
feat: set up CSS partials and main stylesheet
Feature/css partition
…s and testimonials
feat: add components CSS partial with sidebar, navbar, about, service…
feat: add utilities CSS partial with scrollbars, keyframes and helper…
chore: wire up main stylesheet and adjust import paths in HTML
chore: wire up main stylesheet and adjust import paths in HTML
feat: add page navigation logic in js/main.js
deepdevjose
commented
Jul 1, 2025
Owner
Author
deepdevjose
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review: Responsive Two-Column Layout & CSS Refactor
What’s working well 👏
- Splitting CSS into partials (
base.css,layout.css,components.css,utilities.css) greatly improves maintainability. - Using
flex+ media queries at 1024px matches the intended design. - All original styles are preserved with no duplicates or omissions.
Suggestions for improvement 💡
- Rename
.main-contentto a more semantic class (e.g..content-wrapper) to avoid confusion. - Extract the sidebar’s fixed width (
300px) into a CSS variable inbase.cssfor easier future adjustments. - Add a comment above the breakpoint, for example:
/* Two-column layout from 1024px up */
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
styles.cssinto 4 partials undercss/partials/:base.css(imports, variables, resets, global styles)layout.css(page wrapper, sidebar/article, separator, icon-box, fade animation, two-column flex)components.css(UI modules: cards, buttons, sidebar-info, navbar, sections…)utilities.css(helpers, custom scrollbars, keyframes, media queries)<article>in a.main-contentcontainer@media (min-width:1024px), turnmaininto flex:.main-content:flex:1to occupy remaining spacejustify-contenttoflex-startso sidebar stays flush left/* BASE */,/* LAYOUT */, etc.Checklist
@importin a single entry file)