Skip to content

Conversation

@deepdevjose
Copy link
Owner

@deepdevjose deepdevjose commented Jul 1, 2025

Summary

  • Split styles.css into 4 partials under css/partials/:
    • base.css (imports, variables, resets, global styles)
    • layout.css (page wrapper, sidebar/article, separator, icon-box, fade animation, two-column flex)
    • components.css (UI modules: cards, buttons, sidebar-info, navbar, sections…)
    • utilities.css (helpers, custom scrollbars, keyframes, media queries)
  • Updated layout.css to:
    • Wrap all <article> in a .main-content container
    • At @media (min-width:1024px), turn main into flex:
      • Sidebar: fixed 300 px width, sticky below navbar
      • .main-content: flex:1 to occupy remaining space
      • Navbar: absolutely positioned at top-right of content
    • Switched justify-content to flex-start so sidebar stays flush left
  • Kept all existing CSS rules intact, only reorganized under /* BASE */, /* LAYOUT */, etc.
  • Adjusted breakpoints for consistency (1024px layout, 1250px scrollbar tweaks)

Checklist

  • CSS partials imported correctly in HTML (or via @import in a single entry file)
  • Manual tests pass on desktop (>=1024px) and mobile (<1024px)
  • No visual regressions in existing sections

deepdevjose and others added 27 commits June 30, 2025 21:08
feat: set up CSS partials and main stylesheet
feat: add components CSS partial with sidebar, navbar, about, service…
feat: add utilities CSS partial with scrollbars, keyframes and helper…
chore: wire up main stylesheet and adjust import paths in HTML
chore: wire up main stylesheet and adjust import paths in HTML
feat: add page navigation logic in js/main.js
Copy link
Owner Author

@deepdevjose deepdevjose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: Responsive Two-Column Layout & CSS Refactor

What’s working well 👏

  • Splitting CSS into partials (base.css, layout.css, components.css, utilities.css) greatly improves maintainability.
  • Using flex + media queries at 1024px matches the intended design.
  • All original styles are preserved with no duplicates or omissions.

Suggestions for improvement 💡

  • Rename .main-content to a more semantic class (e.g. .content-wrapper) to avoid confusion.
  • Extract the sidebar’s fixed width (300px) into a CSS variable in base.css for easier future adjustments.
  • Add a comment above the breakpoint, for example:
    /* Two-column layout from 1024px up */

@deepdevjose deepdevjose merged commit 167edd3 into main Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants