DP-7586 Fail parsing on unsupported RIB_GENERIC SAFI#3
Merged
dfkyle merged 1 commit intoparse-mrt-rdfrom Mar 30, 2026
Merged
Conversation
ekukura-nokia
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
The RIB_GENERIC parser tries to parse NLRI prefixes for unsupported SAFI types (currently we are only interested in MplsVpn).
The Solution
Skip all unsupported SAFIs. This is what the RFC recommends as well.
Note that RIB_GENERIC is a catch-all for uncommon case entries. Common use cases have dedicated subtypes (c.f. https://datatracker.ietf.org/doc/html/rfc6396#section-4.3.2).
How to Test
Skip tests that make network requests