Skip to content

Tests/updated api tests#70

Closed
RahulJana wants to merge 6 commits intomainfrom
tests/updated_api_tests
Closed

Tests/updated api tests#70
RahulJana wants to merge 6 commits intomainfrom
tests/updated_api_tests

Conversation

@RahulJana
Copy link
Copy Markdown
Collaborator

@RahulJana RahulJana commented Feb 28, 2025

  • Added tests for api.py
    • Check health of the endpoint.
    • Check retrosynthesis endpoint.
    • Check rerun_retrosynthesis endpoint.
  • CI for API tests.
  • General Cleanup of the code base.

@shreyasvinaya
Copy link
Copy Markdown
Collaborator

@RahulJana Can you please rebase the PR with the latest code on main, I will merge it in after the rebase

Copy link
Copy Markdown
Collaborator

@shreyasvinaya shreyasvinaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes required, rest of the code looks good

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RahulJana Please update this file to the latest version

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this empty file

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RahulJana Could you combine the tests for the main retrosynthesis endpoint all into 1 file?
I see different files for pistachio and USPTO

Similarly for rerun_retrosynthesis as well

@shreyasvinaya shreyasvinaya mentioned this pull request May 9, 2025
@RahulJana RahulJana closed this May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants