Skip to content

compute.createJob -> compute.startJob in tests. Fixes #1904 #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brollb merged 1 commit into from
Sep 11, 2020
Merged

compute.createJob -> compute.startJob in tests. Fixes #1904 #1905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion test/unit/common/compute/backends/local/Client.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ describe('local compute', function() {
const testFixture = require('../../../../../globals');
const GeneratedFiles = testFixture.requirejs('deepforge/plugin/GeneratedFiles');
const Compute = testFixture.requirejs('deepforge/compute/index');
const {ComputeJob} = testFixture.requirejs('deepforge/compute/backends/ComputeJob');
const BlobClient = require('webgme-engine/src/server/middleware/blob/BlobClientWithFSBackend');
const gmeConfig = testFixture.getGmeConfig();
const blobClient = new BlobClient(gmeConfig, testFixture.logger);
Expand All @@ -22,7 +23,8 @@ describe('local compute', function() {
}
});

jobInfo = await client.createJob(jobHash);
const computeJob = new ComputeJob(jobHash);
jobInfo = await client.startJob(computeJob);
await deferred.promise;
});

Expand Down
5 changes: 3 additions & 2 deletions test/unit/plugins/ExecuteJob/ExecuteJob.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ describe('ExecuteJob', function () {
}
done();
};
mockCompute.createJob = async () => jobInfo;
mockCompute.startJob = async () => jobInfo;
plugin.compute = mockCompute;

return Q(plugin.createJob(node, jobInfo.hash))
Expand Down Expand Up @@ -264,7 +264,8 @@ describe('ExecuteJob', function () {
});

class MockCompute extends ComputeClient {
createJob(hash) {
startJob(job) {
const {hash} = job;
this.jobId = hash;
return {hash};
}
Expand Down