chore: unblock CI lint gate#45
Merged
lukeocodes merged 2 commits intomainfrom May 1, 2026
Merged
Conversation
The CI Lint job (uv run ruff format --check src/ packages/*/src) was failing on three files I did not touch: - packages/deepctl-cmd-debug-toolkit/src/deepctl_cmd_debug_toolkit/command.py - packages/deepctl-cmd-debug-toolkit/src/deepctl_cmd_debug_toolkit/fetcher.py - packages/deepctl-core/src/deepctl_core/auth.py The format issues exist on origin/main as of c1d6b54, so any PR was blocked until they were reformatted. Applies 'ruff format' to those three files only — no logic changes, just whitespace/wrapping — to unblock this PR (and any other PR currently sitting against main).
Two pre-existing mypy errors on origin/main were blocking the CI Lint gate (the gate runs ruff format + ruff check + mypy --strict against src/ + packages/*/src): 1. 'import deepgram_mcp' in deepctl-cmd-mcp triggered import-untyped errors because the MCP SDK ships without type stubs and was not listed in any ignore_missing_imports override. Adds deepgram_mcp + deepgram_mcp.* to the existing override that already covers the no-stub sounddevice/numpy modules. 2. deepctl_cmd_mcp/models.py imported TransportType from deepgram_mcp then deepctl_cmd_mcp/__init__.py re-exported it from .models, producing 'attribute not explicitly exported' (attr-defined). Fix: use the explicit 'from X import Y as Y' re-export pattern that mypy --strict accepts; drops the now-unnecessary noqa F401 comment. Both verified locally with 'uv run mypy src/ packages/*/src' (the same command CI runs). No logic changes; just config + import-statement shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the CI Lint job (`uv run ruff format --check && ruff check && mypy --strict` against `src/` + `packages/*/src`) to green. Was failing on `origin/main` against pre-existing files, blocking every PR's lint gate until either fixed or admin-overridden.
What it does
5 files, ~30 lines diff. No logic changes — pure config + format + import-statement shape.
Verification
These are the exact commands CI's Lint job runs.
Context
These two fix commits originally landed on the `#42` branch while it was open, but #42 was admin-merged before the fix commits could be picked up. They got stranded on the deleted branch. This PR brings them back as a single small chore so future PRs aren't blocked.