feat!: modernise project to current Deepgram Python standards#20
Merged
lukeocodes merged 1 commit intomainfrom Mar 29, 2026
Merged
feat!: modernise project to current Deepgram Python standards#20lukeocodes merged 1 commit intomainfrom
lukeocodes merged 1 commit intomainfrom
Conversation
- Replace setup.py with pyproject.toml (setuptools backend, ruff/mypy/pytest config) - Add full type hints and docstrings across all source files - Add py.typed PEP 561 marker - Export ConverterException and EmptyTranscriptException from __init__ - Add CI workflow (lint + type check + test matrix on Python 3.10–3.13) - Switch release workflow to PyPI trusted publishing (OIDC, no API token) - Fix PEP 639 license classifier conflict breaking pip install on newer setuptools - Fix datetime.utcfromtimestamp() deprecation for Python 3.12+ compatibility BREAKING CHANGE: webvtt() and srt() now raise EmptyTranscriptException when the converter returns no lines; previously returned an empty string.
lukeocodes
force-pushed
the
chore/modernise-project-standards
branch
from
96e51a1 to
e151b64
Compare
lukeocodes
changed the title
GregHolmes
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setup.pywithpyproject.toml(setuptools backend, ruff/mypy/pytest config, proper classifiers)py.typedPEP 561 markerConverterExceptionandEmptyTranscriptExceptionfrom__init__CHANGELOG.md,SECURITY.md,MakefileCONTRIBUTING.mdwith dev setup,maketargets, and adding-converter guideTrusted publishing setup required
Before the next release, add a trusted publisher at:
https://pypi.org/manage/project/deepgram-captions/settings/publishing/deepgramdeepgram-python-captionsrelease.ymlpypiTest plan
pip install -e ".[dev]" && make checkpassesmake testpasses on Python 3.10, 3.11, 3.12, 3.13