added formatting features #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geekchick
suggested changes
Nov 7, 2022
Contributor
geekchick
left a comment
geekchick
left a comment
There was a problem hiding this comment.
I just have a few questions about the parameter types and a few other things.
deepgram/_types.py
Outdated
Comment on lines
72
to
79
| replace: str | ||
| dates: str | ||
| date_format: str | ||
| times: str | ||
| dictation: str | ||
| measurements: str |
Contributor
There was a problem hiding this comment.
Are we removing the replace parameter?
Also, I wanted to double-check check but should dates, times, dictation, measurements all be booleans and not strings?
Lastly, are we missing smart_format per the documentation?
Contributor
Author
There was a problem hiding this comment.
Sorry about that. Didn't mean to remove replace and thought I had changed those to booleans. Those are updated now.
smart_format isn't ready so it will be a separate ticket.
geekchick
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.