[Fix] 020-twilio-media-streams-node — handle missing ffmpeg in test#63
[Fix] 020-twilio-media-streams-node — handle missing ffmpeg in test#63github-actions[bot] wants to merge 1 commit intomainfrom
Conversation
ffmpeg is no longer pre-installed on all GitHub Actions ubuntu runner images. The test now auto-installs ffmpeg when not found and properly handles null stderr from spawnSync ENOENT errors. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Code ReviewOverall: CHANGES REQUESTED Integration genuineness✓ Pass — this is a test-infrastructure fix only. The underlying example genuinely integrates both Code quality✓ Documentation✓ PR body clearly explains root cause and fix Tests✓ Credential check still runs first with exit code 2 Duplicate concern⚠ This PR appears to be a duplicate of #56, which fixes the exact same issue (missing ffmpeg + null stderr crash) in the exact same file. PR #56 is already labeled Please address the duplicate concern above — if #56 covers this fix, this PR should be closed. If this PR is intended to replace #56, please note that in the PR body and close #56. Review by Lead on 2026-03-30 |
Closing as duplicateRoot cause: This PR fixes the exact same issue (missing ffmpeg + null stderr crash in Action: Closing this PR in favor of #56 to avoid merge conflicts. Both PRs add Fix triage by Lead on 2026-03-30 |
|
Closing as duplicate of #56. |
Summary
Cannot read properties of null (reading 'toString')whenffmpegwas not pre-installed on the GitHub Actions runnerensureFfmpeg()helper that auto-installs ffmpeg via apt-get when not foundstderrhandling inspawnSyncerror path (ENOENT returnsnullfor stderr/stdout)Root cause
GitHub Actions ubuntu runner images no longer guarantee
ffmpegis pre-installed. WhenspawnSync('ffmpeg', ...)fails with ENOENT,result.stderrisnullandresult.statusisnull, causing the existing error handler to crash onresult.stderr.toString().Test plan
🤖 Generated with Claude Code