Permit null log streams, as the code is null safe#2268
Merged
niloc132 merged 1 commit intodeephaven:mainfrom Apr 14, 2022
Merged
Permit null log streams, as the code is null safe#2268niloc132 merged 1 commit intodeephaven:mainfrom
niloc132 merged 1 commit intodeephaven:mainfrom
Conversation
niloc132
force-pushed
the
null-log-streams
branch
from
b234575 to
def9f7d
Compare
devinrsmith
approved these changes
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a server implementation to not provide these print streams if it doesn't want to, by explicitly binding to null.
This is clearly safe, since
providesStreamToRealexplicitly passes nulls along rather than consume the offered params, if certain system properties are set.Partial #2221