ring table for kafka#2290
Merged
devinrsmith merged 3 commits intodeephaven:mainfrom Apr 20, 2022
Merged
Conversation
Member
Author
|
Will likely want to follow-up with docs and examples update. |
jcferretti
previously approved these changes
Apr 20, 2022
jmao-denver
previously approved these changes
Apr 20, 2022
Comment on lines
+98
to
+99
| self._j_spec = j_spec | ||
|
|
Contributor
There was a problem hiding this comment.
is self._j_table_type a better name?
devinrsmith
dismissed stale reviews from jmao-denver and jcferretti
via
ab4acad
jcferretti
approved these changes
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.