Bring latest C++ client work up to the main branch.#2674
Merged
jcferretti merged 5 commits intodeephaven:mainfrom Jul 25, 2022
Merged
Bring latest C++ client work up to the main branch.#2674jcferretti merged 5 commits intodeephaven:mainfrom
jcferretti merged 5 commits intodeephaven:mainfrom
Conversation
… intended to be extended with more sources/classes/code from here.
jcferretti
approved these changes
Jul 25, 2022
Member
jcferretti
left a comment
jcferretti
left a comment
There was a problem hiding this comment.
Did a basic check of the files included in the PR, to ensure there is nothing that could result in disruption in other things not c++ client. Aside from that, we did a more comprehensive review of the same code on Corey's fork here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.