Fixed a race condition in one of the examples#2706
Merged
devinrsmith merged 2 commits intodeephaven:mainfrom Aug 1, 2022
Merged
Fixed a race condition in one of the examples#2706devinrsmith merged 2 commits intodeephaven:mainfrom
devinrsmith merged 2 commits intodeephaven:mainfrom
Conversation
devinrsmith
reviewed
Jul 30, 2022
| return | ||
| } | ||
| defer outputRec.Release() | ||
| for { |
Member
There was a problem hiding this comment.
I'm worried about an infinite loop. At the very least, some sort of limiter. @rcaudy, I'm surprised that upon completion of AddTable that the data might not be available for snapshotting?
devinrsmith
approved these changes
Aug 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the input table example code, I added some rows to an input table and then immediately snapshotted a table derived from it. Sometimes the server doesn't have time to propogate the new rows, though, so the snapshot returns the wrong data.
This fix just snapshots in a loop until we find the correct data. I don't use an explicit timeout here to keep the example simple.
go testhas a default timeout of 1 minute so we don't have to worry about CI hanging.