When an ExportObject runner throws StatusRuntimeException forward to client#2794
Merged
nbauernfeind merged 2 commits intodeephaven:mainfrom Sep 6, 2022
Merged
When an ExportObject runner throws StatusRuntimeException forward to client#2794nbauernfeind merged 2 commits intodeephaven:mainfrom
nbauernfeind merged 2 commits intodeephaven:mainfrom
Conversation
nbauernfeind
force-pushed
the
gh1871_fix
branch
from
905ef97 to
e1d3d10
Compare
devinrsmith
previously approved these changes
Sep 1, 2022
Member
devinrsmith
left a comment
devinrsmith
left a comment
There was a problem hiding this comment.
LGTM - make sure to get Colin signoff, I think he had insight wrt #1871
niloc132
reviewed
Sep 2, 2022
Member
niloc132
left a comment
niloc132
left a comment
There was a problem hiding this comment.
Two cases that need to be tested, that don't go through batch or have an explicit comment about not wanting to call onError on the export builder:
- ScopeTicketResolver.publish calls submit() on the
publishinstance with noonErrorbeing set - ExportTicketResolver.flightInfoFor explicitly throws grpc status ex, but has no
onError
niloc132
approved these changes
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1871