Write a unit test to verify that @FinalDefault is respected#2825
Merged
nbauernfeind merged 2 commits intodeephaven:mainfrom Sep 8, 2022
Merged
Write a unit test to verify that @FinalDefault is respected#2825nbauernfeind merged 2 commits intodeephaven:mainfrom
nbauernfeind merged 2 commits intodeephaven:mainfrom
Conversation
rcaudy
reviewed
Sep 8, 2022
Member
rcaudy
left a comment
rcaudy
left a comment
There was a problem hiding this comment.
What's the runtime for the new test?
Contributor
Author
It takes ~6s. |
rcaudy
approved these changes
Sep 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also wrote tests for the test logic to ensure it catches different override patterns.