Update PartitionTable to use RowSetBuilder instead of RowSet.insert()#2852
Merged
lbooker42 merged 15 commits intodeephaven:mainfrom Sep 19, 2022
lbooker42:lab-partitionby-opt
Merged
Update PartitionTable to use RowSetBuilder instead of RowSet.insert()#2852lbooker42 merged 15 commits intodeephaven:mainfrom lbooker42:lab-partitionby-opt
PartitionTable to use RowSetBuilder instead of RowSet.insert()#2852lbooker42 merged 15 commits intodeephaven:mainfrom
lbooker42:lab-partitionby-opt
Conversation
RowSetBuilder instead of RowSet.insert()RowSetBuilder instead of RowSet.insert()
RowSetBuilder instead of RowSet.insert()PartitionTable to use RowSetBuilder instead of RowSet.insert()
lbooker42
commented
Sep 15, 2022
lbooker42
commented
Sep 15, 2022
lbooker42
commented
Sep 15, 2022
lbooker42
commented
Sep 15, 2022
rcaudy
reviewed
Sep 19, 2022
Member
rcaudy
left a comment
There was a problem hiding this comment.
The changes are generally sound. We can be a little cleaner with allocation.
rcaudy
reviewed
Sep 19, 2022
rcaudy
approved these changes
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Use a sequential builder during the creation stage of the PartitionTable since we can rely on ordered keys, transition to using random builder on following updates.
Initial tests show a 30-90% speedup in some cases (data to follow)
The only regression is in the very large bucket (1M items per bucket) where direct
RowSet.insert()is measurably faster. The other cases greatly benefit from these changes however and the overall change is beneficial.NOTE: It's likely that
groupBy()can also benefit from these changes.