SessionState should tryManage as dependencies may no longer be live#2884
Merged
nbauernfeind merged 2 commits intodeephaven:mainfrom Sep 20, 2022
Merged
Conversation
kosak
previously approved these changes
Sep 20, 2022
rcaudy
previously approved these changes
Sep 20, 2022
kosak
approved these changes
Sep 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows for correct error propagation of StatusRuntimeExceptions from dependencies to downstream exports. The depending exports were failing with Internal errors instead, as non-exports are no longer kept live once put into a terminal state.