Update check-ci-results path to include all build/test-results#3017
Merged
devinrsmith merged 4 commits intodeephaven:mainfrom Oct 25, 2022
Merged
Update check-ci-results path to include all build/test-results#3017devinrsmith merged 4 commits intodeephaven:mainfrom
devinrsmith merged 4 commits intodeephaven:mainfrom
Conversation
devinrsmith
requested review from
JamesXNelson,
jcferretti and
mofojed
as code owners
jcferretti
previously approved these changes
Oct 24, 2022
mofojed
reviewed
Oct 24, 2022
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
I would appreciate more details in the PR description for future context:
- Why the change?
- Any tests performed? E.g. are there only xml files in the folder, are we sure there aren't other things in that folder that would cause issues, etc.
mofojed
previously approved these changes
Oct 24, 2022
``` $ find ~/Downloads/check-ci-results\(3\) -type d -name binary /home/devin/Downloads/check-ci-results(3)/extensions/parquet/table/build/test-results/brotliTest/binary /home/devin/Downloads/check-ci-results(3)/py/jpy-integration/build/test-results/java-to-python-test/binary ```
jcferretti
approved these changes
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go and cpp-client are missing test and log data
The check-ci-results path is too specific, and was built before these client tests existed.