fix: Remove double-wrapping in query_update_performance_map (6883)#7781
Merged
jmao-denver merged 7 commits intodeephaven:mainfrom Mar 11, 2026
Merged
Conversation
…883) The function raises DHError because j_map_to_dict already wraps Java Table values via wrap_j_object, but the function then attempts to wrap them again with Table(j_table=d[k]), causing a jpy.cast ValueError. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
j_map_to_dict already converts Java Table values to Python Table instances via wrap_j_object. The subsequent loop re-wrapping with Table(j_table=d[k]) passed an already-wrapped Python Table to jpy.cast, which only accepts Java objects. Fixes deephaven#6883 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
leochen4891
requested review from
chipkent,
cpwright,
jmao-denver and
rcaudy
as code owners
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
No docs changes detected for a2b90f1 |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
deephaven-internal
added a commit
to deephaven/cla
that referenced
this pull request
Mar 11, 2026
jmao-denver
added
python
NoDocumentationNeeded
NoReleaseNotesNeeded
jmao-denver
changed the title
jmao-denver
reviewed
Mar 11, 2026
Contributor
Author
|
@jmao-denver Nice catch. Thanks. |
jmao-denver
reviewed
Mar 11, 2026
jmao-denver
reviewed
Mar 11, 2026
Co-authored-by: Jianfeng Mao <4297243+jmao-denver@users.noreply.github.com>
jmao-denver
reviewed
Mar 11, 2026
jmao-denver
approved these changes
Mar 11, 2026
Contributor
No problem. The changes look good. I thought I could quickly fix the format issues but human can seldom beat the tools. And thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
perfmon.query_update_performance_map()fails withValueError: cast: argument 1 (obj) must be a Java objectbecausej_map_to_dictalready wraps Java Table values into Python Table instances viawrap_j_object, but the function then tries to wrap them again withTable(j_table=d[k]).The first commit adds a test capturing the existing behavior. The second commit fixes the double-wrapping and updates the test to verify the expected behavior.
Fixes #6883