updated examples repo for directory consistency#58
Merged
Conversation
margaretkennedy
approved these changes
Oct 5, 2021
chipkent
reviewed
Oct 6, 2021
| - **[`taxi`](https://azure.microsoft.com/en-us/services/open-datasets/catalog/nyc-taxi-limousine-commission-yellow-taxi-trip-records/)** - Yellow Taxi trip records | ||
| - **[`tensorflow`](https://www.tensorflow.org/)** - Statistically calculate positive/negative sentiment using machine-learning | ||
| - **[`CryptoCurrency`](./CryptoCurrency)** - Script to pull live and historical data for specified cryptocurencies | ||
| - **[`CsvParquetCrypto`](./CsvParquetCrypto)** - Data from [CoinGecko](https://www.coingecko.com/) to highlight use of CSV and Parquet data formats. |
Member
There was a problem hiding this comment.
This directory name feels awkward compared to the others. It is:
- extremely specific. What if we want to add another file format in the future?
- fells like it is named backwards
Consider a name likeCryptoCurrencyHistory.
Contributor
Author
There was a problem hiding this comment.
I took the name that was previously there, but I agree, I think CryptoCurrencyHistory would be great. I'll make a PR for this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.