-
Notifications
You must be signed in to change notification settings - Fork 3
feat: DH-20954: MCP status bar toggle #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No docs changes detected for 19711c5 |
End-to-end Test Summary
Failed Test SummaryNo failed tests ✨ |
Unit Test Summary
Failed Test SummaryNo failed tests ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances MCP server usability by allowing users to toggle the workspace-level MCP setting and manage the server directly from a status bar item and new commands. It wires configuration updates to start/stop behavior and adds a quick pick UI for enabling/disabling and copying the server URL.
Changes:
- Extend
IConfigServiceandConfigServicewith atoggleMcphelper that flips or setsdeephaven.mcp.enabledat workspace scope. - Update
McpControllerto register new commands, drive the status bar via a management quick pick instead of direct copy, and reflect enabled/disabled state in the status bar. - Register new
showMcpQuickPickandtoggleMcpcommands incommands.tsandpackage.json, including command palette entries and configuration contributions.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/types/serviceTypes.d.ts |
Adds toggleMcp to IConfigService so controllers can trigger MCP enable/disable via the config service. |
src/services/ConfigService.ts |
Implements toggleMcp to update deephaven.mcp.enabled in workspace scope and exposes it via ConfigService. |
src/controllers/McpController.ts |
Registers TOGGLE_MCP_CMD and SHOW_MCP_QUICK_PICK_CMD, adds a quick pick for enable/disable/copy actions, and updates the MCP status bar to show port or “Disabled” and launch the quick pick. |
src/common/commands.ts |
Defines the new SHOW_MCP_QUICK_PICK_CMD and TOGGLE_MCP_CMD command IDs used by the controller and manifest. |
package.json |
Contributes the new MCP management commands (including the Deephaven: Toggle MCP Server palette entry) and wires them into the commandPalette menu conditions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DH-20954: MCP status bar item can now toggle mcp server setting and will stop / start the MCP server accordingly. Easier to see status now for whether a workspace has the server running.
Testing
> Deephaven: Toggle MCP Servercommand nowdeephaven.mcp.enabled