Skip to content

Conversation

@bmingles
Copy link
Collaborator

@bmingles bmingles commented Feb 4, 2026

DH-20954: MCP status bar item can now toggle mcp server setting and will stop / start the MCP server accordingly. Easier to see status now for whether a workspace has the server running.

Testing

  • MCP status bar item should open quick pick menu
  • If already enabled, quick pick shows option to disable + one to copy the server url
  • If already disabled, shows option to enable
  • Command palette also has a > Deephaven: Toggle MCP Server command now
  • Toggling should update workspace level setting deephaven.mcp.enabled

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

No docs changes detected for 19711c5

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

End-to-end Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
330000016:48:47
A ctrf plugin

Failed Test Summary

No failed tests ✨

@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Unit Test Summary

Tests 📝Passed ✅Failed ❌Skipped ⏭️Pending ⏳Other ❓Flaky 🍂Duration ⏱️
5685680000000:00:00
A ctrf plugin

Failed Test Summary

No failed tests ✨

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances MCP server usability by allowing users to toggle the workspace-level MCP setting and manage the server directly from a status bar item and new commands. It wires configuration updates to start/stop behavior and adds a quick pick UI for enabling/disabling and copying the server URL.

Changes:

  • Extend IConfigService and ConfigService with a toggleMcp helper that flips or sets deephaven.mcp.enabled at workspace scope.
  • Update McpController to register new commands, drive the status bar via a management quick pick instead of direct copy, and reflect enabled/disabled state in the status bar.
  • Register new showMcpQuickPick and toggleMcp commands in commands.ts and package.json, including command palette entries and configuration contributions.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/types/serviceTypes.d.ts Adds toggleMcp to IConfigService so controllers can trigger MCP enable/disable via the config service.
src/services/ConfigService.ts Implements toggleMcp to update deephaven.mcp.enabled in workspace scope and exposes it via ConfigService.
src/controllers/McpController.ts Registers TOGGLE_MCP_CMD and SHOW_MCP_QUICK_PICK_CMD, adds a quick pick for enable/disable/copy actions, and updates the MCP status bar to show port or “Disabled” and launch the quick pick.
src/common/commands.ts Defines the new SHOW_MCP_QUICK_PICK_CMD and TOGGLE_MCP_CMD command IDs used by the controller and manifest.
package.json Contributes the new MCP management commands (including the Deephaven: Toggle MCP Server palette entry) and wires them into the commandPalette menu conditions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mofojed
mofojed previously approved these changes Feb 4, 2026
@bmingles bmingles merged commit 3d9d229 into main Feb 4, 2026
6 checks passed
@bmingles bmingles deleted the DH-20954-9_mcp-status-bar branch February 4, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants