fix: Typing for WritableStream#1186
Merged
mofojed merged 2 commits intodeephaven:mainfrom Mar 30, 2023
Merged
Conversation
Member
mofojed
commented
Mar 29, 2023
mofojed
commented
- Import in a different file and just export it
- Use implicit typing to work around the issue
- Fixes Fix type error in TableSaver.tsx #803
- Import in a different file and just export it - Use implicit typing to work around the issue - Fixes deephaven#803
dsmmcken
reviewed
Mar 29, 2023
Codecov Report
@@ Coverage Diff @@
## main #1186 +/- ##
==========================================
- Coverage 44.19% 44.18% -0.01%
==========================================
Files 448 448
Lines 33310 33308 -2
Branches 8364 8362 -2
==========================================
- Hits 14720 14718 -2
Misses 18541 18541
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dsmmcken
approved these changes
Mar 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.