fix: Cannot import CSV with LOCAL_TIME#1434
Merged
mofojed merged 3 commits intodeephaven:mainfrom Aug 1, 2023
Merged
Conversation
- We were adding an empty string as the command, which prevented it from appearing as an error in the console history
- LOCAL_TIME is not supported on the DHC server currently - Rather than erroring out, just have it map to a String. User can then map to an Instant or something with an `update_view`.
Codecov Report
@@ Coverage Diff @@
## main #1434 +/- ##
==========================================
- Coverage 45.71% 45.71% -0.01%
==========================================
Files 511 511
Lines 35070 35073 +3
Branches 8769 8772 +3
==========================================
+ Hits 16033 16034 +1
- Misses 18986 18988 +2
Partials 51 51
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Collaborator
mattrunyon
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

''instead ofundefinedLOCAL_TIMEisn't supported on the server in DHC, and isn't really "safe" anyways since we should have other info in there as well (e.g. date or time zone).update_viewto map it to a timestamp if they wishCan't parse LOCAL_TIMEexception in the logs, no error shown #1432