Skip to content

fix: flaky e2e tests#1453

Merged
mattrunyon merged 22 commits intodeephaven:mainfrom
ethanalvizo:e2e-fix
Aug 31, 2023
Merged

fix: flaky e2e tests#1453
mattrunyon merged 22 commits intodeephaven:mainfrom
ethanalvizo:e2e-fix

Conversation

@ethanalvizo
Copy link
Copy Markdown
Contributor

@ethanalvizo ethanalvizo commented Aug 18, 2023

Fixes:

  • code not pasting/typing into editor
  • deleting tables between tests
  • menus not closing between steps
  • using dblclick over drag when possible

Does not fix:

  • table disconnect observed on DHC version 0.27.1

@ethanalvizo ethanalvizo self-assigned this Aug 18, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (6ff27a6) 45.75% compared to head (0bcec5b) 45.74%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1453      +/-   ##
==========================================
- Coverage   45.75%   45.74%   -0.01%     
==========================================
  Files         515      516       +1     
  Lines       35073    35095      +22     
  Branches     8784     8785       +1     
==========================================
+ Hits        16048    16055       +7     
- Misses      18974    18989      +15     
  Partials       51       51              
Flag Coverage Δ
unit 45.74% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/iris-grid/src/CrossColumnSearch.tsx 8.64% <ø> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ethanalvizo ethanalvizo changed the title fix: error logging fix: flake e2e tests Aug 23, 2023
@ethanalvizo ethanalvizo changed the title fix: flake e2e tests fix: flaky e2e tests Aug 23, 2023
@ethanalvizo ethanalvizo marked this pull request as ready for review August 25, 2023 19:37
Comment thread tests/utils.ts Outdated
Comment thread tests/table-operations.spec.ts Outdated
mofojed
mofojed previously approved these changes Aug 28, 2023
Comment thread tests/utils.ts Outdated
@mattrunyon mattrunyon requested a review from mofojed August 31, 2023 21:37
@mattrunyon mattrunyon merged commit d59e9be into deephaven:main Aug 31, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants