feat: improve table loading#1898
feat: improve table loading#1898wusteven815 merged 9 commits intodeephaven:mainfrom wusteven815:improve-table-loading
Conversation
|
Switched to events |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1898 +/- ##
=======================================
Coverage 46.11% 46.11%
=======================================
Files 637 637
Lines 38054 38077 +23
Branches 9620 9626 +6
=======================================
+ Hits 17549 17561 +12
- Misses 20452 20463 +11
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mofojed
left a comment
There was a problem hiding this comment.
iris-grid-loading element that gets loaded blocks all user interaction while scrolling... also, the Cancel button doesn't make sense in this context. It will try and rollback the state of filters etc. which doesn't make sense, and you can't really "cancel" a viewport operation.
Instead, I don't think we should show the cancel button, and we shouldn't stop the user from interacting/scrolling the table either. We just want the loading status in the bottom. So we may need to add another loading state value or something.
mofojed
left a comment
There was a problem hiding this comment.
Just some cleanup/suggestions.
If we wanted to get really fancy, we'd keep a list of the pending operations and their type, then decide what loading text/spinner to display at render time based on all the current pending operations. In theory, this could also help us with our rollback before (right now we just rollback to the last loaded state). I think that's all out of scope for right now though, this is good.
startLoadingwill block the grid or show the cancel button