Golden layout fallback for unregistered components#194
Merged
vbabich merged 5 commits intodeephaven:mainfrom Sep 14, 2021
Merged
Golden layout fallback for unregistered components#194vbabich merged 5 commits intodeephaven:mainfrom
vbabich merged 5 commits intodeephaven:mainfrom
Conversation
mofojed
requested changes
Sep 13, 2021
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Great stuff, just remove the console.log statements and it should be good.
Co-authored-by: Mike Bender <mikebender@deephaven.io>
Co-authored-by: Mike Bender <mikebender@deephaven.io>
mofojed
approved these changes
Sep 14, 2021
Merged
mofojed
added a commit
to mofojed/web-client-ui
that referenced
this pull request
Oct 14, 2021
* `code-studio`, `iris-grid` * [deephaven#199](deephaven#199) Remove default formatting rules ([@mofojed](https://github.com/mofojed)) * `code-studio`, `golden-layout` * [deephaven#194](deephaven#194) Golden layout fallback for unregistered components ([@vbabich](https://github.com/vbabich)) * `iris-grid` * [deephaven#206](deephaven#206) Fix up some issues with input tables ([@mofojed](https://github.com/mofojed)) * `code-studio`, `iris-grid` * [deephaven#199](deephaven#199) Remove default formatting rules ([@mofojed](https://github.com/mofojed)) * Other * [deephaven#211](deephaven#211) Remove unnecessary uses flag ([@mofojed](https://github.com/mofojed)) * [deephaven#210](deephaven#210) Add registry-url back, add release action ([@mofojed](https://github.com/mofojed)) * [deephaven#209](deephaven#209) Fix the registry used when publishing ([@mofojed](https://github.com/mofojed)) * [deephaven#204](deephaven#204) Update publish actions ([@mofojed](https://github.com/mofojed)) * `golden-layout` * [deephaven#198](deephaven#198) Fix package-lock in golden-layout ([@mofojed](https://github.com/mofojed)) - Mike Bender ([@mofojed](https://github.com/mofojed)) - [@vbabich](https://github.com/vbabich)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #184