refactor: Rename ButtonGroup to SplitButtonGroup#1997
refactor: Rename ButtonGroup to SplitButtonGroup#1997bmingles merged 5 commits intodeephaven:mainfrom
ButtonGroup to SplitButtonGroup#1997Conversation
|
Shouldn't touch ButtonOld, I have no expectation of it having compatibility. I should just refactor it out entirely. |
|
Did you mean to do that on Button? |
|
@dsmmcken I'm planning to do this on Button as well. ButtonOld just happened to be the first attempt since it is used in the Styleguide where I was testing. |
aff98bb to
13385ea
Compare
ButtonGroup to SplitButtonGroup
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1997 +/- ##
==========================================
+ Coverage 46.34% 46.37% +0.03%
==========================================
Files 673 668 -5
Lines 38762 38704 -58
Branches 9818 9799 -19
==========================================
- Hits 17963 17949 -14
+ Misses 20746 20702 -44
Partials 53 53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
What's the reason for the rename? Don't see anything here or in the ticket |
It's to allow us to re-export Spectrum ButtonGroup. I updated the ticket description with details. |
0b4a2f0 to
55e9a71
Compare
Renaming
ButtonGrouptoSplitButtonGroupto avoid naming collisions with Spectrum.resolves #2015
BREAKING CHANGE: Renamed @deephaven/components
ButtonGrouptoSplitButtonGroup