Fix scroll bar not working in the corner if only one scroll direction#233
Merged
mofojed merged 2 commits intodeephaven:mainfrom Oct 14, 2021
Merged
Fix scroll bar not working in the corner if only one scroll direction#233mofojed merged 2 commits intodeephaven:mainfrom
mofojed merged 2 commits intodeephaven:mainfrom
Conversation
Member
mofojed
commented
Oct 13, 2021
mofojed
commented
- The scroll mouse handlers always assumed the other scroll bar was showing and there was always a corner
- Check if there's a scroll bar needed in the other direction to calculate the proper height
- Fixes Dead corner in grid scrolling when attempting to click in bottom right corner #231
- The scroll mouse handlers always assumed the other scroll bar was showing and there was always a corner - Check if there's a scroll bar needed in the other direction to calculate the proper height - Fixes deephaven#231
Contributor
|
Noticed a minor issue because this is now working correctly, in
|
dsmmcken
approved these changes
Oct 14, 2021
mofojed
added a commit
to mofojed/web-client-ui
that referenced
this pull request
Oct 14, 2021
* [deephaven#232](deephaven#232) Fix notebook functionality ([@mofojed](https://github.com/mofojed)) * `code-studio`, `components`, `dashboard-core-plugins` * [deephaven#228](deephaven#228) Fix card flip animation showing back-face in chrome ([@dsmmcken](https://github.com/dsmmcken)) * `grid` * [deephaven#233](deephaven#233) Fix scroll bar not working in the corner if only one scroll direction ([@mofojed](https://github.com/mofojed)) * `dashboard-core-plugins` * [deephaven#230](deephaven#230) Fix up getTableMapForDashboard selector ([@mofojed](https://github.com/mofojed)) - Don ([@dsmmcken](https://github.com/dsmmcken)) - Mike Bender ([@mofojed](https://github.com/mofojed))
Merged
mofojed
added a commit
that referenced
this pull request
Oct 14, 2021
* [#232](#232) Fix notebook functionality ([@mofojed](https://github.com/mofojed)) * `code-studio`, `components`, `dashboard-core-plugins` * [#228](#228) Fix card flip animation showing back-face in chrome ([@dsmmcken](https://github.com/dsmmcken)) * `grid` * [#233](#233) Fix scroll bar not working in the corner if only one scroll direction ([@mofojed](https://github.com/mofojed)) * `dashboard-core-plugins` * [#230](#230) Fix up getTableMapForDashboard selector ([@mofojed](https://github.com/mofojed)) - Don ([@dsmmcken](https://github.com/dsmmcken)) - Mike Bender ([@mofojed](https://github.com/mofojed))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.