Skip to content

fix: fix format options#2353

Merged
jnumainville merged 2 commits intodeephaven:mainfrom
jnumainville:18091_indicator_format_fix
Jan 29, 2025
Merged

fix: fix format options#2353
jnumainville merged 2 commits intodeephaven:mainfrom
jnumainville:18091_indicator_format_fix

Conversation

@jnumainville
Copy link
Contributor

It appears that decimal and integer format options weren't correctly passing through so the chart was not receiving updates.

@codecov
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 46.76%. Comparing base (40dfcb7) to head (3f177dd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/chart/src/Chart.tsx 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2353      +/-   ##
==========================================
- Coverage   46.76%   46.76%   -0.01%     
==========================================
  Files         710      710              
  Lines       39107    39109       +2     
  Branches     9773     9774       +1     
==========================================
  Hits        18288    18288              
- Misses      20808    20810       +2     
  Partials       11       11              
Flag Coverage Δ
unit 46.76% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jnumainville jnumainville merged commit 3869b50 into deephaven:main Jan 29, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants