Skip to content

fix: Partition aware source table UI widget swaps from merge to coalesce#2397

Merged
ericlln merged 6 commits intodeephaven:mainfrom
ericlln:DH-19015-PartitionAwareSourceTable-UI-Widget-Swaps-from-Merge-to-Coalesce
Mar 28, 2025
Merged

fix: Partition aware source table UI widget swaps from merge to coalesce#2397
ericlln merged 6 commits intodeephaven:mainfrom
ericlln:DH-19015-PartitionAwareSourceTable-UI-Widget-Swaps-from-Merge-to-Coalesce

Conversation

@ericlln
Copy link
Copy Markdown
Contributor

@ericlln ericlln commented Mar 27, 2025

  • Fixes the observed issue of the partition selector button flipping between Merge and Coalesce depending on which partition view is selected.
  • The original condition for isPartitionAwareSourceTable in IrisGridTableModel.ts isn't always accurate as table.isUncoalesced is only true when no filters have been applied yet. Once a filter is applied, the table is no longer considered uncoalesced but the source table should still have the same property as before.
  • Test snippet is linked on the ticket: DH-19015

@ericlln ericlln requested a review from a team March 27, 2025 17:53
@ericlln ericlln self-assigned this Mar 27, 2025
@ericlln ericlln requested review from dgodinez-dh and removed request for a team March 27, 2025 17:53
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 46.82%. Comparing base (99dfcab) to head (c607b70).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/iris-grid/src/IrisGridProxyModel.ts 0.00% 4 Missing ⚠️
packages/iris-grid/src/IrisGridTableModel.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2397      +/-   ##
==========================================
- Coverage   46.82%   46.82%   -0.01%     
==========================================
  Files         711      711              
  Lines       39289    39295       +6     
  Branches    10007     9821     -186     
==========================================
+ Hits        18398    18400       +2     
- Misses      20837    20884      +47     
+ Partials       54       11      -43     
Flag Coverage Δ
unit 46.82% <16.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ericlln ericlln merged commit f6a859d into deephaven:main Mar 28, 2025
15 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants