fix: DH-19010: Delete closed http2 sessions from the cache#2400
Merged
bmingles merged 1 commit intodeephaven:mainfrom Mar 31, 2025
Merged
Conversation
bmingles
requested review from
a team and
vbabich
and removed request for
a team
vbabich
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DH-19010: Delete closed http2 sessions from the cache. This ensures new sessions get created on next request since closed sessions cannot be re-used.
Note that this is currently only used by the VS Code extension. I tested it locally, but final testing will happen as part of the PR that updates DH packages to use this change.