Skip to content

refactor: Add isOrganizeColumnsAvailable flag to IrisGrid#2405

Merged
vbabich merged 1 commit intodeephaven:mainfrom
vbabich:feat_isOrganizeColumnsAvailable_flag
Apr 3, 2025
Merged

refactor: Add isOrganizeColumnsAvailable flag to IrisGrid#2405
vbabich merged 1 commit intodeephaven:mainfrom
vbabich:feat_isOrganizeColumnsAvailable_flag

Conversation

@vbabich
Copy link
Copy Markdown
Collaborator

@vbabich vbabich commented Apr 3, 2025

Controls visiblity of the Organize Columns menu in Table Options

@vbabich vbabich requested a review from Copilot April 3, 2025 14:57
@vbabich vbabich self-assigned this Apr 3, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new flag, isOrganizeColumnsAvailable, to control the visibility of the Organize Columns menu in Table Options. Key changes include:

  • Adding a getter for isOrganizeColumnsAvailable that returns true in IrisGridTreeTableModel and IrisGridTableModelTemplate.
  • Adding a getter for isOrganizeColumnsAvailable that returns false in IrisGridModel.
  • Updating IrisGrid.tsx to incorporate the new flag in the component’s options.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/iris-grid/src/IrisGridTreeTableModel.ts Adds a getter returning true for isOrganizeColumnsAvailable
packages/iris-grid/src/IrisGridTableModelTemplate.ts Adds a getter returning true for isOrganizeColumnsAvailable
packages/iris-grid/src/IrisGridModel.ts Introduces a getter returning false for isOrganizeColumnsAvailable; note inconsistency
packages/iris-grid/src/IrisGrid.tsx Incorporates the new flag in the options list
Comments suppressed due to low confidence (1)

packages/iris-grid/src/IrisGridModel.ts:435

  • The value for isOrganizeColumnsAvailable is set to false in IrisGridModel, while the corresponding getters in IrisGridTreeTableModel and IrisGridTableModelTemplate return true. Consider making the behavior consistent to avoid unexpected UI discrepancies.
return false;

@vbabich vbabich requested review from a team and dgodinez-dh and removed request for a team April 3, 2025 15:35
@vbabich vbabich merged commit 0f4f238 into deephaven:main Apr 3, 2025
10 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants