Skip to content

fix: DH-13244: remove trailing whitespace from console log messages#2418

Merged
dgodinez-dh merged 1 commit intodeephaven:mainfrom
dgodinez-dh:dag_TrailingWhiteSpace
Apr 24, 2025
Merged

fix: DH-13244: remove trailing whitespace from console log messages#2418
dgodinez-dh merged 1 commit intodeephaven:mainfrom
dgodinez-dh:dag_TrailingWhiteSpace

Conversation

@dgodinez-dh
Copy link
Copy Markdown
Contributor

https://deephaven.atlassian.net/browse/DH-13244

There was a fix for single line console messages here: #350
However, this fix did not account for trailing newline characters in the message. This fix trims whitespace from the end of the message.

@dgodinez-dh dgodinez-dh requested review from a team and bmingles and removed request for a team April 23, 2025 16:21
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 46.84%. Comparing base (2533670) to head (f43fbb2).

Files with missing lines Patch % Lines
...nsole-history/ConsoleHistoryResultErrorMessage.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2418      +/-   ##
==========================================
- Coverage   46.84%   46.84%   -0.01%     
==========================================
  Files         711      711              
  Lines       39319    39320       +1     
  Branches     9826    10015     +189     
==========================================
  Hits        18418    18418              
+ Misses      20890    20848      -42     
- Partials       11       54      +43     
Flag Coverage Δ
unit 46.84% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgodinez-dh dgodinez-dh merged commit 2827f51 into deephaven:main Apr 24, 2025
11 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 24, 2025
@dgodinez-dh dgodinez-dh deleted the dag_TrailingWhiteSpace branch May 1, 2026 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants