fix: DH-19693: Add null/empty formatting to constituent strings #2495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v0.85 #2495 +/- ##
=================================================
+ Coverage 47.36% 47.40% +0.04%
=================================================
Files 710 710
Lines 39528 39534 +6
Branches 10064 9880 -184
=================================================
+ Hits 18721 18741 +20
- Misses 20752 20782 +30
+ Partials 55 11 -44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gzh2003
force-pushed
the
pick-DH-19693-to-v0.85
branch
from
97def9b to
f2a0a40
Compare
gzh2003
changed the title
…haven#2464) Part of DH-19693. Anything that renders as "empty" for empty strings, and "null" for null strings, should still render the same when rolledup. This adds the missing null and empty string formatting logic for tree table constituent values. Changes: - Checks if the result should show "null" or "empty" based on formatter
Follow-up to deephaven#2461. This PR adds e2e tests for constituent formatting.
gzh2003
force-pushed
the
pick-DH-19693-to-v0.85
branch
from
f2a0a40 to
ef350cc
Compare
mofojed
changed the title
mofojed
approved these changes
Jul 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #2464 and #2480 to
v0.85Part of DH-19693. Anything that renders as "empty" for empty strings, and "null" for null strings, should still render the same when rolledup. This adds the missing null and empty string formatting logic for tree table constituent values.
Changes:
Checks if the result should show "null" or "empty" based on formatter
test: DH-19614: e2e tests for constituent formatting
Follow-up to #2461. This PR adds e2e tests for constituent formatting.