Skip to content

fix: DH-18443: Add variableName to ItemContainer#2525

Closed
jnumainville wants to merge 1 commit intodeephaven:mainfrom
jnumainville:18443_config_name
Closed

fix: DH-18443: Add variableName to ItemContainer#2525
jnumainville wants to merge 1 commit intodeephaven:mainfrom
jnumainville:18443_config_name

Conversation

@jnumainville
Copy link
Copy Markdown
Contributor

@jnumainville jnumainville commented Aug 19, 2025

Adds a variable name in support of deephaven/deephaven-plugins#1226
Currently the title is passed through the container and that can be overriden to not be the variable name, so I thought this would be a simple solution to bundle that information.

Required for deephaven/deephaven-plugins#1226

@jnumainville jnumainville requested a review from Copilot August 19, 2025 19:04
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for passing a variable name through the ItemContainer configuration to support better handling of variable names in deephaven-plugins. The change ensures that variable names can be preserved separately from titles, which may be overridden for display purposes.

  • Adds optional variableName property to ItemContainer configuration type
  • Updates both the class property declaration and constructor assignment to include the new field

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 44.61%. Comparing base (21c06c0) to head (73c72a0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...kages/golden-layout/src/container/ItemContainer.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2525   +/-   ##
=======================================
  Coverage   44.61%   44.61%           
=======================================
  Files         764      764           
  Lines       42800    42800           
  Branches    10766    10766           
=======================================
  Hits        19096    19096           
  Misses      23693    23693           
  Partials       11       11           
Flag Coverage Δ
unit 44.61% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jnumainville jnumainville requested a review from mofojed August 20, 2025 14:43
@jnumainville jnumainville marked this pull request as ready for review August 20, 2025 14:44
@jnumainville
Copy link
Copy Markdown
Contributor Author

Unnecessary, there is a simpler way to do deephaven/deephaven-plugins#1226

@github-actions github-actions Bot locked and limited conversation to collaborators Aug 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants