fix: DH-18443: Add variableName to ItemContainer#2525
fix: DH-18443: Add variableName to ItemContainer#2525jnumainville wants to merge 1 commit intodeephaven:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for passing a variable name through the ItemContainer configuration to support better handling of variable names in deephaven-plugins. The change ensures that variable names can be preserved separately from titles, which may be overridden for display purposes.
- Adds optional
variableNameproperty to ItemContainer configuration type - Updates both the class property declaration and constructor assignment to include the new field
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2525 +/- ##
=======================================
Coverage 44.61% 44.61%
=======================================
Files 764 764
Lines 42800 42800
Branches 10766 10766
=======================================
Hits 19096 19096
Misses 23693 23693
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Unnecessary, there is a simpler way to do deephaven/deephaven-plugins#1226 |
Adds a variable name in support of deephaven/deephaven-plugins#1226
Currently the title is passed through the container and that can be overriden to not be the variable name, so I thought this would be a simple solution to bundle that information.
Required for deephaven/deephaven-plugins#1226