fix: DH-21843: Fix unexpected code studio unmount#2672
Merged
dgodinez-dh merged 9 commits intodeephaven:mainfrom May 6, 2026
Merged
fix: DH-21843: Fix unexpected code studio unmount#2672dgodinez-dh merged 9 commits intodeephaven:mainfrom
dgodinez-dh merged 9 commits intodeephaven:mainfrom
Conversation
Contributor
dgodinez-dh
commented
May 6, 2026
- added unit test that mimics the race condition of the bug
- added unit test for expected behavior when a layout should change
- change DashboardLayout lastConfig to a ref
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2672 +/- ##
==========================================
- Coverage 49.78% 49.77% -0.02%
==========================================
Files 774 774
Lines 43917 43946 +29
Branches 11129 11330 +201
==========================================
+ Hits 21866 21873 +7
- Misses 22033 22054 +21
- Partials 18 19 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.