Skip to content

fix: Spectrum version bump and pin#2689

Merged
jnumainville merged 7 commits into
deephaven:mainfrom
jnumainville:update_spectrum_3.47.0
Jun 2, 2026
Merged

fix: Spectrum version bump and pin#2689
jnumainville merged 7 commits into
deephaven:mainfrom
jnumainville:update_spectrum_3.47.0

Conversation

@jnumainville
Copy link
Copy Markdown
Contributor

@jnumainville jnumainville commented May 26, 2026

React Spectrum recently switched from independent packages to packages bound to a specific @adobe/react-spectrum version (in minor version bumps across packages). This has led to some broken testing in deephaven/deephaven-plugins#1349 and was flagged as an issue in an enterprise version bump by Copilot.
As an example, note the dependency switch from 5.9.0 to 5.10.0 of @react-spectrum/overlays.
This PR pins specific and consistent versions for all react spectrum packages, as well as related ones, even if they aren't in the spectrum namespace, to prevent breakages.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.47%. Comparing base (75fd09c) to head (449636e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2689      +/-   ##
==========================================
+ Coverage   50.22%   50.47%   +0.24%     
==========================================
  Files         787      787              
  Lines       44836    44836              
  Branches    11612    11609       -3     
==========================================
+ Hits        22517    22629     +112     
+ Misses      22300    22188     -112     
  Partials       19       19              
Flag Coverage Δ
unit 50.47% <ø> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jnumainville jnumainville requested review from a team, bmingles and Copilot and removed request for a team May 27, 2026 17:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the monorepo’s React Spectrum dependency set to a newer release and fixes a related type import breakage by re-exporting/consuming the dialog “close” callback type from the local Spectrum barrel.

Changes:

  • Bump @adobe/react-spectrum from 3.38.0 to 3.47.0 across multiple workspace packages.
  • Align/pin several Spectrum ecosystem dependencies in @deephaven/components to versions compatible with the bump.
  • Re-export SpectrumDialogClose from the local Spectrum overlay exports and update ActionButtonDialogTrigger to import it from ../spectrum.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react-hooks/package.json Bumps @adobe/react-spectrum to 3.47.0.
packages/components/src/spectrum/overlays.ts Re-exports SpectrumDialogClose from @adobe/react-spectrum.
packages/components/src/dialogs/ActionButtonDialogTrigger.tsx Switches SpectrumDialogClose import to come from the local Spectrum barrel.
packages/components/package.json Bumps @adobe/react-spectrum and updates related Spectrum dependency versions.
packages/code-studio/package.json Bumps @adobe/react-spectrum to 3.47.0.
packages/app-utils/package.json Bumps @adobe/react-spectrum to 3.47.0.
package-lock.json Lockfile refresh reflecting the Spectrum/version realignment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jnumainville jnumainville changed the title fix: spectrum bump fix: Spectrum version bump and pin May 27, 2026
@jnumainville jnumainville marked this pull request as ready for review May 27, 2026 17:44
Comment on lines +38 to +51
"@react-aria/focus": "3.22.0",
"@react-aria/i18n": "3.13.0",
"@react-spectrum/label": "3.17.0",
"@react-spectrum/overlays": "5.10.0",
"@react-spectrum/theme-default": "3.6.0",
"@react-spectrum/toast": "3.2.0",
"@react-spectrum/utils": "3.13.0",
"@react-stately/overlays": "3.7.0",
"@react-stately/utils": "3.12.0",
"@react-types/combobox": "3.15.0",
"@react-types/radio": "3.9.0",
"@react-types/shared": "3.34.0",
"@react-types/textfield": "3.12.4",
"@spectrum-icons/ui": "3.7.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What determines which versions you pinned here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was the packages that were released with "@adobe/react-spectrum": "3.47.0", or at least should have been... two were off but have been fixed.

Copy link
Copy Markdown
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a question about where version numbers came from. Looks good otherwise

Copy link
Copy Markdown
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@jnumainville jnumainville merged commit f099b41 into deephaven:main Jun 2, 2026
16 of 18 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants