fix: Spectrum version bump and pin#2689
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2689 +/- ##
==========================================
+ Coverage 50.22% 50.47% +0.24%
==========================================
Files 787 787
Lines 44836 44836
Branches 11612 11609 -3
==========================================
+ Hits 22517 22629 +112
+ Misses 22300 22188 -112
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates the monorepo’s React Spectrum dependency set to a newer release and fixes a related type import breakage by re-exporting/consuming the dialog “close” callback type from the local Spectrum barrel.
Changes:
- Bump
@adobe/react-spectrumfrom3.38.0to3.47.0across multiple workspace packages. - Align/pin several Spectrum ecosystem dependencies in
@deephaven/componentsto versions compatible with the bump. - Re-export
SpectrumDialogClosefrom the local Spectrum overlay exports and updateActionButtonDialogTriggerto import it from../spectrum.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react-hooks/package.json | Bumps @adobe/react-spectrum to 3.47.0. |
| packages/components/src/spectrum/overlays.ts | Re-exports SpectrumDialogClose from @adobe/react-spectrum. |
| packages/components/src/dialogs/ActionButtonDialogTrigger.tsx | Switches SpectrumDialogClose import to come from the local Spectrum barrel. |
| packages/components/package.json | Bumps @adobe/react-spectrum and updates related Spectrum dependency versions. |
| packages/code-studio/package.json | Bumps @adobe/react-spectrum to 3.47.0. |
| packages/app-utils/package.json | Bumps @adobe/react-spectrum to 3.47.0. |
| package-lock.json | Lockfile refresh reflecting the Spectrum/version realignment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@react-aria/focus": "3.22.0", | ||
| "@react-aria/i18n": "3.13.0", | ||
| "@react-spectrum/label": "3.17.0", | ||
| "@react-spectrum/overlays": "5.10.0", | ||
| "@react-spectrum/theme-default": "3.6.0", | ||
| "@react-spectrum/toast": "3.2.0", | ||
| "@react-spectrum/utils": "3.13.0", | ||
| "@react-stately/overlays": "3.7.0", | ||
| "@react-stately/utils": "3.12.0", | ||
| "@react-types/combobox": "3.15.0", | ||
| "@react-types/radio": "3.9.0", | ||
| "@react-types/shared": "3.34.0", | ||
| "@react-types/textfield": "3.12.4", | ||
| "@spectrum-icons/ui": "3.7.0", |
There was a problem hiding this comment.
What determines which versions you pinned here?
There was a problem hiding this comment.
It was the packages that were released with "@adobe/react-spectrum": "3.47.0", or at least should have been... two were off but have been fixed.
bmingles
left a comment
There was a problem hiding this comment.
Just had a question about where version numbers came from. Looks good otherwise
bmingles
left a comment
There was a problem hiding this comment.
Changes look good to me.
React Spectrum recently switched from independent packages to packages bound to a specific
@adobe/react-spectrumversion (in minor version bumps across packages). This has led to some broken testing in deephaven/deephaven-plugins#1349 and was flagged as an issue in an enterprise version bump by Copilot.As an example, note the dependency switch from 5.9.0 to 5.10.0 of
@react-spectrum/overlays.This PR pins specific and consistent versions for all react spectrum packages, as well as related ones, even if they aren't in the spectrum namespace, to prevent breakages.