DH-11632 handle LH frozen columns in the UI#272
Conversation
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
Some cleanup needed.
Also, this should work for floatingRightColumnCount, but we're not actually using that yet, I would file a follow up ticket for that (or do it right away).
| const columnX = visibleColumnXs.get(column); | ||
| const columnWidth = visibleColumnWidths.get(column); | ||
|
|
||
| if (!(columnX < floatingLeftColumnsWidth - columnWidth)) { |
There was a problem hiding this comment.
This is a little bit weird, no need to change though... I just think it would make more sense if it drew all the visible column headers, and then drew all the floating column headers overtop (with backgrounds so it draws over the separators).
There was a problem hiding this comment.
Actually after inspecting further, there is some overlap occurring when I'm testing in the styleguide:
There was a problem hiding this comment.
I really can't repro this. We might need to screen-share...I'll post the rest of the review fixes in the meantime.
There was a problem hiding this comment.
Looks like it's only reproducible when the row headers are visible, which we have in the style guide. I set a breakpoint in the drawColumnHeaders when it was filling in the background to figure out the floating background it was drawing was a bit off:
Just needed to offset the background drawing by gridX instead of 0
|
|
use gridX for offset instead of 0 Co-authored-by: Mike Bender <mikebender@deephaven.io>
2 participants
There is some possible refactoring optimization to be had in
drawColumnHeadersbut it looked quite ugly locally since the loops contents relied on too many scoped+calculated vars. Still open to suggestions in either case.