Skip to content

do not collapse console errors on mouseUp#275

Merged
spasovski merged 6 commits intodeephaven:mainfrom
spasovski:davor_fix_192
Nov 12, 2021
Merged

do not collapse console errors on mouseUp#275
spasovski merged 6 commits intodeephaven:mainfrom
spasovski:davor_fix_192

Conversation

@spasovski
Copy link
Contributor

@spasovski spasovski commented Nov 3, 2021

fixes #192

This was clearly intentionally allowed before but I agree the new behaviour is better.

@spasovski spasovski requested a review from mofojed November 3, 2021 19:03
@spasovski spasovski self-assigned this Nov 3, 2021
@spasovski spasovski added the enhancement New feature or request label Nov 4, 2021
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don reviewed this for UX? You can't select the first line of the exception, we need to be able to select the full exception.

@dsmmcken
Copy link
Contributor

dsmmcken commented Nov 9, 2021

true, not sure it's any better, it just shifted the problem from the body to the button.

@spasovski
Copy link
Contributor Author

The button text is selectable (though not easily) - I'd float a copy to clipboard button to the far right of the error expand button and we can manually write the full text to the clipboard.

@mofojed
Copy link
Member

mofojed commented Nov 10, 2021

You can't select the button/top line of text at all right now? A floating copy button might be handy for copying a particular exception, but you should also just be able to copy the console output in general (eg. if you have a bunch of logging lines, then an exception, more logging, you should be able to select all that).

mofojed
mofojed previously approved these changes Nov 11, 2021
@spasovski spasovski merged commit b8ce2ff into deephaven:main Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Click in an expanded exception in the Console should not collapse it

3 participants