Skip to content

Fix issue where tables would not reload after refreshing the page#287

Merged
mofojed merged 3 commits intodeephaven:mainfrom
mofojed:fix-reload
Nov 11, 2021
Merged

Fix issue where tables would not reload after refreshing the page#287
mofojed merged 3 commits intodeephaven:mainfrom
mofojed:fix-reload

Conversation

@mofojed
Copy link
Member

@mofojed mofojed commented Nov 11, 2021

Two fixes:

  • The "Close Panels on Disconnect" option wasn't working. This is because I was emitting the incorrect event (nothing listened to ControlEvent.CLOSE anymore)
  • If the "Close Panels on Disconnect" option was not selected, the tables would not re-open on browser refresh. This is because I was passing the table name in the id field, instead of the name field.

Fixes #286

Was using the `id` field instead of the `name` field.
@mofojed mofojed added bug Something isn't working web-client-ui labels Nov 11, 2021
@mofojed mofojed added this to the November 2021 milestone Nov 11, 2021
@mofojed mofojed requested a review from vbabich November 11, 2021 22:14
@mofojed mofojed self-assigned this Nov 11, 2021
I deleted all the ControlEvent, and just added it to PanelEvent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working web-client-ui

Projects

None yet

2 participants