DH-11661 refresh viewport on IrisGridTableMode.handleTotalsUpdate#297
Merged
spasovski merged 2 commits intodeephaven:mainfrom Nov 16, 2021
Merged
DH-11661 refresh viewport on IrisGridTableMode.handleTotalsUpdate#297spasovski merged 2 commits intodeephaven:mainfrom
spasovski merged 2 commits intodeephaven:mainfrom
Conversation
mofojed
requested changes
Nov 16, 2021
Member
mofojed
left a comment
mofojed
left a comment
There was a problem hiding this comment.
I don't think this is the fix we want - doing a quick debug reproducing the issue (prior to this fix), it looks like we are getting a totals update, and even updating with the new colours/formatting, but for some reason the old value is drawn.
If you've got a sec let's screen share and figure it out.
mofojed
approved these changes
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if this is the ideal path but the event detail and copyTotalsData were doing the right thing yet the aggs table wasn't updating until a viewport change happened. Easy review though!