Enable code coverage tests, add thresholds#298
Merged
mofojed merged 4 commits intodeephaven:mainfrom Nov 22, 2021
Merged
Conversation
Started with a baseline threshold just below existing levels.
mofojed
changed the title
- We don't really need the fancy reporters because we don't have anything that will consume them at this time - No need to output to coverageDir
mofojed
changed the title
Collaborator
|
Running |
Member
Author
|
@vbabich I'm not getting the same error as you - do you have another flag or enter another command afterwards? Running just |
vbabich
previously approved these changes
Nov 22, 2021
The HTML ones in particular are good for drilling down into which code blocks aren't getting hit.
vbabich
approved these changes
Nov 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started with a baseline threshold just below existing levels for the whole project.
However, since the coverage report only runs on existing changes, it will check your diff and fail if they fall below those levels.
Only using the 'text' type reporter as that will be output in our console or in CI log output and we can see the failures from there.