Convert GridMetricCalculator, GridRange, GridUtils to TypeScript#302
Merged
mofojed merged 13 commits intodeephaven:mainfrom Nov 25, 2021
Merged
Convert GridMetricCalculator, GridRange, GridUtils to TypeScript#302mofojed merged 13 commits intodeephaven:mainfrom
mofojed merged 13 commits intodeephaven:mainfrom
Conversation
All tests pass, did a quick smoke test and things work as expected
spasovski
reviewed
Nov 18, 2021
spasovski
reviewed
Nov 18, 2021
spasovski
previously approved these changes
Nov 18, 2021
Contributor
spasovski
left a comment
spasovski
left a comment
There was a problem hiding this comment.
Looks good. Glad this is moving forward.
mattrunyon
requested changes
Nov 18, 2021
- Correct 'eg.' to 'e.g.' - Renamed Index to VisibleIndex - Renamed itemXs to itemCoordinates to be a little more accurate
Missed a few comments the first time
mattrunyon
reviewed
Nov 19, 2021
mattrunyon
requested changes
Nov 19, 2021
- Now that it throws if we're trying to retrieve a value that's not in the map, needed a couple more fixes. - Add the floating rows/columns heights to the height/column maps right away, before we calculate all the positions - Check if columnCount or rowCount is 0 before getting some values
mattrunyon
requested changes
Nov 23, 2021
Closed
mattrunyon
requested changes
Nov 24, 2021
Collaborator
mattrunyon
left a comment
mattrunyon
left a comment
There was a problem hiding this comment.
Change mapGet to be called something like getOrThrow or mapGetOrThrow to make it clear to anybody in the future that it can throw
Remove default value if you want
mattrunyon
approved these changes
Nov 24, 2021
mofojed
added a commit
to mofojed/web-client-ui
that referenced
this pull request
Nov 26, 2021
…ipt (deephaven#302)" This reverts commit 3b46b7a.
mofojed
added a commit
to mofojed/web-client-ui
that referenced
this pull request
Nov 26, 2021
…phaven#302) - Convert part of grid to TypeScript - Add some JSDocs
Merged
mofojed
added a commit
that referenced
this pull request
Dec 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.