Skip to content

Fix codecov problems#333

Merged
mattrunyon merged 2 commits intodeephaven:mainfrom
mattrunyon:codecov-fix
Dec 7, 2021
Merged

Fix codecov problems#333
mattrunyon merged 2 commits intodeephaven:mainfrom
mattrunyon:codecov-fix

Conversation

@mattrunyon
Copy link
Collaborator

Codecov should be updated on push to main so diffs against main work properly. Also limits the action to search for coverage only in the coverage directory

@mattrunyon mattrunyon added the bug Something isn't working label Dec 7, 2021
@mattrunyon mattrunyon requested a review from mofojed December 7, 2021 19:55
@mattrunyon mattrunyon self-assigned this Dec 7, 2021
mofojed
mofojed previously approved these changes Dec 7, 2021
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #333 (5490a83) into main (fadd327) will increase coverage by 22.90%.
The diff coverage is 0.00%.

❗ Current head 5490a83 differs from pull request most recent head a8c621a. Consider uploading reports for the commit a8c621a to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main     #333       +/-   ##
===========================================
+ Coverage   39.69%   62.59%   +22.90%     
===========================================
  Files         328        1      -327     
  Lines       23275      524    -22751     
  Branches     4956      163     -4793     
===========================================
- Hits         9238      328     -8910     
+ Misses      13615      173    -13442     
+ Partials      422       23      -399     
Flag Coverage Δ
unit 62.59% <0.00%> (+22.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/chart/src/ChartUtils.js 62.59% <0.00%> (-0.58%) ⬇️
packages/iris-grid/src/filters/FilterOperator.js
packages/iris-grid/src/TableUtils.js
packages/iris-grid/src/IrisGridModel.js
...rc/mousehandlers/IrisGridDataSelectMouseHandler.js
packages/grid/src/key-handlers/EditKeyHandler.ts
.../format-context-menus/DateTimeFormatContextMenu.js
packages/components/src/popper/index.ts
packages/components/src/context-actions/index.ts
... and 319 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fadd327...a8c621a. Read the comment docs.

Make codecov action only search for our coverage directory

Chnge file to test codecov works

Remove code change to test codecov

Test code changes again
@mattrunyon mattrunyon merged commit 7e80fbb into deephaven:main Dec 7, 2021
@mattrunyon mattrunyon deleted the codecov-fix branch December 7, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants