Fix the formatting of aggregation rows#334
Merged
mofojed merged 1 commit intodeephaven:mainfrom Dec 8, 2021
Merged
Conversation
- Before it was using the formatting from the column in the table. Instead, use the totals table column type/formatting - Wipe out formatted data when updating totals table
Codecov Report
@@ Coverage Diff @@
## main #334 +/- ##
===========================================
- Coverage 39.69% 27.03% -12.66%
===========================================
Files 328 7 -321
Lines 23275 2079 -21196
Branches 4956 613 -4343
===========================================
- Hits 9238 562 -8676
+ Misses 13615 1292 -12323
+ Partials 422 225 -197
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
vbabich
approved these changes
Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for https://deephaven.atlassian.net/browse/DH-12008