Skip to content

Fix the formatting of aggregation rows#334

Merged
mofojed merged 1 commit intodeephaven:mainfrom
mofojed:agg-formatting
Dec 8, 2021
Merged

Fix the formatting of aggregation rows#334
mofojed merged 1 commit intodeephaven:mainfrom
mofojed:agg-formatting

Conversation

@mofojed
Copy link
Member

@mofojed mofojed commented Dec 7, 2021

  • Before it was using the formatting from the column in the table. Instead, use the totals table column type/formatting
  • Wipe out formatted data when updating totals table

Fix for https://deephaven.atlassian.net/browse/DH-12008

- Before it was using the formatting from the column in the table. Instead, use the totals table column type/formatting
- Wipe out formatted data when updating totals table
@mofojed mofojed added bug Something isn't working web-client-ui labels Dec 7, 2021
@mofojed mofojed requested a review from vbabich December 7, 2021 21:32
@mofojed mofojed self-assigned this Dec 7, 2021
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #334 (2f1063d) into main (fadd327) will decrease coverage by 12.65%.
The diff coverage is 8.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #334       +/-   ##
===========================================
- Coverage   39.69%   27.03%   -12.66%     
===========================================
  Files         328        7      -321     
  Lines       23275     2079    -21196     
  Branches     4956      613     -4343     
===========================================
- Hits         9238      562     -8676     
+ Misses      13615     1292    -12323     
+ Partials      422      225      -197     
Flag Coverage Δ
unit 27.03% <8.33%> (-12.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/iris-grid/src/IrisGridTableModel.js 45.27% <8.33%> (-1.51%) ⬇️
packages/iris-grid/src/TableUtils.js 15.26% <0.00%> (-51.03%) ⬇️
packages/iris-grid/src/IrisGridUtils.js 11.89% <0.00%> (-35.49%) ⬇️
packages/iris-grid/src/Formatter.js 63.41% <0.00%> (-27.29%) ⬇️
packages/iris-grid/src/MissingKeyError.ts 0.00% <0.00%> (-16.67%) ⬇️
packages/iris-grid/src/memoizeClear.js 44.44% <0.00%> (-5.56%) ⬇️
packages/iris-grid/src/IrisGridModel.js 11.21% <0.00%> (-1.63%) ⬇️
...grid/src/mouse-handlers/GridRowTreeMouseHandler.js
packages/components/src/ButtonOld.jsx
... and 319 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fadd327...2f1063d. Read the comment docs.

@mofojed mofojed merged commit 6f849d1 into deephaven:main Dec 8, 2021
@mofojed mofojed deleted the agg-formatting branch December 8, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working web-client-ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants