Merged
Conversation
API changed custom columns to an object, but they can (and should) be stringified for saving.
Codecov Report
@@ Coverage Diff @@
## main #336 +/- ##
===========================================
- Coverage 39.69% 17.64% -22.05%
===========================================
Files 328 21 -307
Lines 23275 3729 -19546
Branches 4956 942 -4014
===========================================
- Hits 9238 658 -8580
+ Misses 13615 2818 -10797
+ Partials 422 253 -169
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
vbabich
reviewed
Dec 7, 2021
| const { columns, customColumns: oldCustomColumns } = model; | ||
| const { columns } = model; | ||
| const oldCustomColumns = model.customColumns.map( | ||
| customColumn => `${customColumn}` |
Collaborator
There was a problem hiding this comment.
Nice, I didn't know we can serialize custom columns like this!
vbabich
approved these changes
Dec 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API changed custom columns to an object, but they can (and should) be stringified for saving.
Fix for Enterprise https://deephaven.atlassian.net/browse/DH-11906