Skip to content

Add event-target-shim to LogProxy#52

Merged
mofojed merged 1 commit intodeephaven:mainfrom
mofojed:mofojed/issue51
Jun 2, 2021
Merged

Add event-target-shim to LogProxy#52
mofojed merged 1 commit intodeephaven:mainfrom
mofojed:mofojed/issue51

Conversation

@mofojed
Copy link
Member

@mofojed mofojed commented Jun 1, 2021

Needed for Safari <14

Needed for Safari <14
@mofojed mofojed requested a review from mattrunyon June 1, 2021 21:39
@mofojed mofojed self-assigned this Jun 1, 2021
@mofojed
Copy link
Member Author

mofojed commented Jun 1, 2021

I ran ./node_modules/.bin/lerna add event-target-shim --scope=@deephaven/log to add the event-target-shim lib, so I think the updates to the package-lock.jsons is also correct (removing the common packages from each package-lock.json to have it only in the highest level package-lock.json)

Copy link
Collaborator

@mattrunyon mattrunyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure our packages should have been removed from code-studio package lock

@mofojed mofojed merged commit 431e8d4 into deephaven:main Jun 2, 2021
@mofojed mofojed added the bug Something isn't working label Jun 2, 2021
@mofojed
Copy link
Member Author

mofojed commented Jun 2, 2021

Fixes #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opening Code Studio in Safari 12 shows a blank screen, error in logs

2 participants